This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Remove command_line_handler_continuation.
- From: Vladimir Prus <vladimir at codesourcery dot com>
- To: Daniel Jacobowitz <drow at false dot org>, Eli Zaretskii <eliz at gnu dot org>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Sat, 3 May 2008 19:58:36 +0400
- Subject: Re: [RFA] Remove command_line_handler_continuation.
- References: <200804242033.40568.vladimir@codesourcery.com> <20080502150314.GL29202@caradoc.them.org>
On Friday 02 May 2008 19:03:14 Daniel Jacobowitz wrote:
> On Thu, Apr 24, 2008 at 07:33:40PM +0300, Vladimir Prus wrote:
> >
> > With my previous patch to move all bpstat_do_actions calls into
> > event handler, all that command_line_handler_continuation does
> > is to print timings, if those are enabled. However, those timings
> > don't make much sense. Timings are good for debugging GDB performance,
> > and in case of command_line_handler_continuation, the times will report
> > the time when the application run.
> >
> > So, this patch removes that continuation. OK?
>
> OK once you and Eli agree about documenting the timings.
Here's a revision with doc clarification. Eli, does it look sufficient?
- Volodya