This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc/rft] ppc gdbserver: autodetect AltiVec and SPE


Daniel Jacobowitz wrote:

> It looks like we've fallen afoul of the code which fetches the
> first register set, then if it is not available does not try any
> further register sets.  So when we try PTRACE_GETVRREGS and fail
> we never try PTRACE_GETEVRREGS.
> 
> This code's bitten me before.  It's even worse now, because if which
> ptrace operations succeed depends on the inferior's mode, the values
> may change during multi.  So I've pulled it out.  The attached patch,
> combined with yours, produces no regressions on any of (SPE, AltiVec,
> classic PowerPC).

Ah, good catch.  Thank you very much for testing my patch (and fixing
the problems!).

> Want to check them both in?

Sure, I've now checked them in.

Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]