This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] fix for PR2424
- From: Vladimir Prus <vladimir at codesourcery dot com>
- To: Aleksandar Ristovski <ARistovski at qnx dot com>
- Cc: Daniel Jacobowitz <drow at false dot org>, gdb-patches at sources dot redhat dot com, nickrob at snap dot net dot nz
- Date: Wed, 16 Apr 2008 12:11:53 +0400
- Subject: Re: [patch] fix for PR2424
- References: <4804BF23.10505@qnx.com>
On Tuesday 15 April 2008 18:43:47 Aleksandar Ristovski wrote:
> Daniel Jacobowitz wrote:
> > On Mon, Apr 14, 2008 at 10:41:38AM -0400, Aleksandar Ristovski wrote:
> >> ping?
> >
> > Thanks. The most recent version of this patch (code + testsuite) is OK.
> >
> > Please mention the PR at the top of the changelog entry, like this:
> >
> > DATE NAME <ADDR>
> >
> > PR gdb/2424
> > * infrun.c (some change): ....
> >
> > Then if you include that line in the commit message, the changelog
> > entry is automatically appended to the PR audit trail.
> >
> > Shouldn't the disp="del" field be described in the manual? If so,
> > that can be a separate patch.
> >
> Committed.
>
> NOTE1 (reminder): With this patch, we have new field in the *stopped
> message,
> when "reason == breakpoint-hit" - we will have "disp" field printed; the
> value
> of the field will be exactly the same as the value printed when the
> breakpoint
> was created.
>
> NOTE2: Due to quite significant rework of certain functions in
> mi-support.exp,
> committed diff for testsuite is not exactly the same as the one I posted. I
> took
> liberty to commit anyway since the changes are functionally the same; note
> the
> slightly awkward syntax for "mi_expect_stop" call, namely the "extra"
> argument
> which now must be something like { "" "disp=\"keep\"" } - I don't think it's
> too
> bad (it can be beautified later).
Can you post the final patch that was checked in, so that I glance on
testsuite changes?
- Volodya