This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] : current_gdbarch replacement in breakpoint.c
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: deuling at de dot ibm dot com (Markus Deuling)
- Cc: gdb-patches at sourceware dot org (GDB Patches)
- Date: Thu, 17 Jan 2008 15:30:04 +0100 (CET)
- Subject: Re: [rfc] : current_gdbarch replacement in breakpoint.c
Markus Deuling wrote:
> - if ((!within_current_scope || fr == get_current_frame ())
> - && gdbarch_in_function_epilogue_p (current_gdbarch, read_pc ()))
> - return WP_VALUE_NOT_CHANGED;
> + if (!within_current_scope)
> + {
> + fr = get_current_frame ();
This does not look correct to me. The old code checked for the in-epilogue
situation when FR was the current frame; your code simply removes that check.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com