This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] TUI do not display current execution point
- From: Daniel Jacobowitz <drow at false dot org>
- To: Pierre Muller <muller at ics dot u-strasbg dot fr>
- Cc: 'Denis PILAT' <denis dot pilat at st dot com>, gdb-patches at sourceware dot org
- Date: Wed, 19 Dec 2007 10:04:00 -0500
- Subject: Re: [RFA] TUI do not display current execution point
- References: <47691CE9.9020302@st.com> <001001c84246$ed9fb5b0$c8df2110$@u-strasbg.fr>
On Wed, Dec 19, 2007 at 02:56:18PM +0100, Pierre Muller wrote:
> Code in gdb directory (utils.c and top.c)
> using PATH_MAX first check if that macro is defined.
>
> Shouldn't you do the same in that patch?
Yes. Also, please correct the ChangeLog entry; you're changing
MAX_LOCATOR_ELEMENT_LEN so that goes in parentheses.
Changing it to a bigger hardcoded constant is OK in this case,
although the right fix would be to remove the hardcoded length
(that's in the GNU Coding Standards, I think).
--
Daniel Jacobowitz
CodeSourcery