This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
gdbserver corrupts binary data in remote protocol
- From: Mick Davis <mickd at goanna dot iinet dot net dot au>
- To: gdb-patches at sourceware dot org
- Date: Thu, 06 Dec 2007 23:05:57 +0900
- Subject: gdbserver corrupts binary data in remote protocol
- Reply-to: mickd at goanna dot iinet dot net dot au
I believe I've found a small bug when using the gdbserver to write into
target memory.
If the command received by the server uses a binary encoded data part,
the remote protocol will clear the most significant bit of each byte.
This may result in a CRC failure. The fix is to the readchar function,
which applies a bit mask to the returned byte.
Thanks
--
Mick Davis
Goanna Technologies Pty Ltd
ChangeLog entry:
2007-12-06 Mick Davis <mickd@goanna.iinet.net.au>
* gdbserver/remote-utils.c (readchar): Allow binary data in received
messages
Index: src/gdb/gdbserver/remote-utils.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/remote-utils.c,v
retrieving revision 1.50
diff -c -p -r1.50 remote-utils.c
*** src/gdb/gdbserver/remote-utils.c 23 Aug 2007 18:08:48 -0000 1.50
--- src/gdb/gdbserver/remote-utils.c 6 Dec 2007 13:23:05 -0000
*************** readchar (void)
*** 722,728 ****
bufp = buf;
bufcnt--;
! return *bufp++ & 0x7f;
}
/* Read a packet from the remote machine, with error checking,
--- 722,728 ----
bufp = buf;
bufcnt--;
! return *bufp++;
}
/* Read a packet from the remote machine, with error checking,