Re: [RFA] Stop infrun from tracking breakpoint insertion status.

[Vladimir Prus <vladimir at codesourcery dot com>]

On Monday 26 November 2007 18:24:56 Ulrich Weigand wrote:
> Vladimir Prus wrote:
> 
> > On Thursday 22 November 2007 03:49:22 you wrote:
> > > Hmmm, if it helps, I could run a test on AIX, which does use
> > > TARGET_WAITKIND_LOADED.
> > 
> > That would surely help in convincing ourself the patch don't
> > break anything.
> 
> I did a test run on AIX now, and unfortunately it did break.
> 
> I didn't look into the failure in detail, but apparently it
> is unrelated to TARGET_WAITKIND_LOADED, but rather to software
> single-step support:

There were in fact two distinct problems. The first was
in my previous patch to document infrun logic -- while the
patch was meant to have no logic change, the case of 
stepping over breakpoint using software single step was
messed up. This patch fixes the problem -- it was tested
on arm-linux/qemu, which uses software single step, with
no test result changes. OK?

- Volodya

        * infrun.c (resume): Set right thread
        even if stepping over breakpoint using software
        single step.
---
 gdb/infrun.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/gdb/infrun.c b/gdb/infrun.c
index 85d889a..00cd2a5 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -605,7 +605,8 @@ a command like `return' or `jump' to continue execution."));
          resume_ptid = inferior_ptid;
        }
 
-      if (step && breakpoint_here_p (read_pc ())
+      if ((step || singlestep_breakpoints_inserted_p)
+         && breakpoint_here_p (read_pc ())
          && !breakpoint_inserted_here_p (read_pc ()))
        {
          /* We're stepping, have breakpoint at PC, and it's 
-- 
1.5.3.5