This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[ob] remove stale comments about permanent breakpoints
- From: Vladimir Prus <vladimir at codesourcery dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Fri, 23 Nov 2007 19:56:45 +0300
- Subject: [ob] remove stale comments about permanent breakpoints
I've noticed that insert_breakpoints/insert_bp_location have
comments about not inserting permanent breakpoints. Those comments
are stale -- the permanent breakpoints are not inserted because
bp_location has 'inserted' field set to 1, not for any other reason.
The comment also say that we don't insert disabled breakpoints, but
that fact is obvious from the code anyway.
This patch, checked in as obvious, removes those comments.
- Volodya
Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.8954
diff -u -p -r1.8954 ChangeLog
--- ChangeLog 23 Nov 2007 16:33:11 -0000 1.8954
+++ ChangeLog 23 Nov 2007 16:53:19 -0000
@@ -1,3 +1,8 @@
+2007-11-23 Vladimir Prus <vladimir@codesourcery.com>
+
+ * breakpoint.c (insert_breakpoints)
+ (insert_bp_location): Remove stale comments.
+
2007-11-23 Maciej W. Rozycki <macro@mips.com>
* mips-linux-tdep.h: Fix some formatting.
Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.283
diff -u -p -r1.283 breakpoint.c
--- breakpoint.c 20 Nov 2007 17:37:34 -0000 1.283
+++ breakpoint.c 23 Nov 2007 16:53:21 -0000
@@ -842,8 +842,6 @@ insert_bp_location (struct bp_location *
{
int val = 0;
- /* Permanent breakpoints cannot be inserted or removed. Disabled
- breakpoints should not be inserted. */
if (!breakpoint_enabled (bpt->owner))
return 0;
@@ -1241,8 +1239,6 @@ insert_breakpoints (void)
ALL_BP_LOCATIONS_SAFE (b, temp)
{
- /* Permanent breakpoints cannot be inserted or removed. Disabled
- breakpoints should not be inserted. */
if (!breakpoint_enabled (b->owner))
continue;