This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] [03/05] Get rid of current_gdbarch in register_sim_regno
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: deuling at de dot ibm dot com (Markus Deuling)
- Cc: gdb-patches at sourceware dot org (GDB Patches)
- Date: Fri, 16 Nov 2007 19:44:08 +0100 (CET)
- Subject: Re: [rfc] [03/05] Get rid of current_gdbarch in register_sim_regno
Markus Deuling wrote:
> Ok, finished. I dont see a caller of this routine. Is it still needed anywhere or could it
> be deleted? If not, than this is the patch. Ok ?
See Andrew's note (last sentence):
/* NOTE: cagney/2002-05-13: The old code did it this way and it is
suspected that some GDB/SIM combinations may rely on this
behavour. The default should be one2one_register_sim_regno
(below). */
The one2one_register_sim_regno function is already prepared as the
routine that *should* be used where possible, even though it is
not yet used anywhere ... I think we should keep it for now.
> * gdbarch.sh (register_sim_regno): Add gdbarch as parameter.
> * gdbarch.{c,h}: Regenerate.
>
> * arch-utils.h (legacy_register_sim_regno): Add gdbarch as parameter.
> * score-tdep.c (score_register_sim_regno): Likewise.
> * sim-regno.h (one2one_register_sim_regno): Likewise.
>
> * arch-utils.c (legacy_register_sim_regno): Add gdbarch as parameter.
> Replace current_gdbarch by gdbarch.
> * sh-tdep.c (sh_sh2a_register_sim_regno)
> (sh_dsp_register_sim_regno): Likewise.
> * rs6000-tdep.c (rs6000_register_sim_regno): Likewise.
> * mips-tdep.c (mips_register_sim_regno): Likewise.
> * m32c-tdep.c (m32c_register_sim_regno): Likewise.
> * frv-tdep.c (frv_register_sim_regno): Likewise.
> * arm-tdep.c (arm_register_sim_regno): Likewise.
> * remote-sim.c (one2one_register_sim_regno): Likewise.
This is OK.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com