This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc] [00/15] Add gdbarch to register_name callback


Markus Deuling wrote:

> All 15 patches depend on each other. Leaving one out at commit will break one or more targets.

Sorry, but it doesn't make sense to split it into distinct patches then.
Every patch should be a self-contained unit (e.g. to allow reverting a
commit if that turns out to be necessary later on).

Could you please merge all co-dependent changes into a single patch
and ChangeLog?   On the other hand, some of the patches contain
additional changes unrelated to the register_name prototype change
-- *those* should be broken out into a second patch.

Otherwise, the changes look fine to me.

Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]