This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Remote watchpoint support for FRV


On Sun, Oct 14, 2007 at 09:55:11PM +0200, Ulrich Weigand wrote:
> Thus it would appear that the STOPPED_BY_WATCHPOINT and 
> target_stopped_data_address macros defined in the tm-frv.h header
> file aren't actually ever called.  (Since the recent watchpoint change,
> they *are* active, but probably not correctly as common code now assumes
> continuable watchpoint behaviour).
> 
> Note that the HAVE_STEPPABLE_WATCHPOINT macro is commented out since the
> very first version of tm-frv.h checked into the GDB CVS, so I'm not sure
> what to think of that ...  Did this ever work?
> 
> If it actually didn't ever work, I'd say we should just remove the tm
> file now; if somebody wants to get remote watchpoint support on frv
> working, they can (and should) use the existing mechanism.

Probably the submitter meant to finish up watchpoint support later.

At this stage, I agree with you that we should simply remove the file.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]