Re: Windows DLL support update.

[Daniel Jacobowitz <drow at false dot org>]

On Thu, Aug 16, 2007 at 01:40:48AM +0100, Pedro Alves wrote:
> I gave it another testsuite spin, and it looks good.

I have one concern; one of us should fix the problem Ulrich pointed
out with my core changes:

> On Tue, Jun 19, 2007 at 09:05:51PM +0200, Ulrich Weigand wrote:
> > One thing I don't quite like is this:
> >
> > > +    case TARGET_OBJECT_LIBRARIES:
> > > +      if (core_vec->xfer_shared_libraries != NULL)
> > > +   return core_vec->xfer_shared_libraries (ops, object, annex,
> > > readbuf,
> > > +                                          writebuf, offset, len);
> >
> > I had understood the core_fns method of providing a core file target
> > to
> > be deprecated, and in fact I just recently got rid of it for AIX in
> > favour
> > of the gdbarch_regset_from_core_section callback ...   I'd prefer
> > this to
> > be a gdbarch callback (which would also support core file
> > cross-debugging).
>
> I hadn't even thought about it.  Yes, you're right.

Also, we added #include's so the Makefile needs an update.

> +/* Returns 1 if ADDR is within the cygwin1.dll text segment, returns 0
> +   otherwise.  */
> +static int
> +inside_cygwin (CORE_ADDR addr)
> +{
> +  if (cygwin_load_start == 0)
> +    {
> +      struct so_list *so;
> +
> +      for (so = master_so_list (); so; so = so->next)

Nothing outside of the solib implementations calls master_so_list.  I
think that's best; can you use ALL_OBJFILES here instead?

> +  if (data->module_count == 0)
> +    {
> +#if 0
> +      /* TODO: What if the user supplied exec and/or
> +	 symbol files on the command line?  */
> +      /* The first module is the .exe itself.  */
> +      symbol_file_add_main (module_name, 0);
> +#endif
> +    }
> +  else
> +    {
> +      struct so_list *so = win32_make_so (module_name, base_addr);
> +      solib_to_xml (so, data->obstack);
> +      win32_free_so (so);
> +    }
> +  data->module_count++;

Let's not add #if 0 / TODO.  I think we can drop this code, how about
you?

Other than that it looks good to me if it looks good to Chris.

-- 
Daniel Jacobowitz
CodeSourcery