This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: PATCH: readline/kill.c, resource leak
- From: Jim Blandy <jimb at codesourcery dot com>
- To: msnyder at sonic dot net
- Cc: gdb-patches at sourceware dot org, bug-readline at gnu dot org
- Date: Tue, 14 Aug 2007 16:48:25 -0700
- Subject: Re: PATCH: readline/kill.c, resource leak
- References: <17725.12.7.175.2.1185934412.squirrel@webmail.sonic.net>
Looks good.
msnyder@sonic.net writes:
> 2007-07-31 Michael Snyder <msnyder@access-company.com>
>
> * kill.c (rl_yank_nth_arg_internal): Resource leak.
>
> Index: kill.c
> ===================================================================
> RCS file: /cvs/src/src/readline/kill.c,v
> retrieving revision 1.6
> diff -p -r1.6 kill.c
> *** kill.c 5 May 2006 18:26:12 -0000 1.6
> --- kill.c 1 Aug 2007 02:01:15 -0000
> *************** rl_yank_nth_arg_internal (count, ignore,
> *** 582,587 ****
> --- 582,589 ----
> if (!arg || !*arg)
> {
> rl_ding ();
> + if (arg)
> + free (arg);
> return -1;
> }
>