This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] [04/12] Get rid of current_gdbarch in frame.c
- From: Jim Blandy <jimb at codesourcery dot com>
- To: Markus Deuling <deuling at de dot ibm dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Ulrich Weigand <uweigand at de dot ibm dot com>
- Date: Fri, 03 Aug 2007 12:37:27 -0700
- Subject: Re: [rfc] [04/12] Get rid of current_gdbarch in frame.c
- References: <46B31B20.2020501@de.ibm.com>
Markus Deuling <deuling@de.ibm.com> writes:
> this patch gets rid of some of the current_gdbarch's in frame.c
>
> Is this ok to commit?
Yes, this looks fine --- thank you!
It took me a bit to realize that "FRAME" and "REGCACHE" in your
ChangeLog entry were references to function arguments. But those
aren't really the names the arguments have in those functions. Could
you say "Use the architecture of the frame or regcache values received
as arguments"?