This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: gdb.base/dump.exp: Force the correct endianness
- From: Jim Blandy <jimb at codesourcery dot com>
- To: "Maciej W. Rozycki" <macro at mips dot com>
- Cc: gdb-patches at sourceware dot org, "Maciej W. Rozycki" <macro at linux-mips dot org>
- Date: Wed, 25 Jul 2007 09:02:34 -0700
- Subject: Re: gdb.base/dump.exp: Force the correct endianness
- References: <Pine.LNX.4.61.0707241727040.20726@perivale.mips.com>
"Maciej W. Rozycki" <macro@mips.com> writes:
> Testcases in gdb.base/dump.exp use binary formats that do not carry
> endianness information. This causes failures if gdb supports both
> endiannesses, but the original binary used by the script is of the
> non-default one.
>
> The following fix has been successfully tested for mipsisa32-sde-elf,
> with the mips-sim-sde32/-EB and mips-sim-sde32/-EL target boards. Gdb
> defaults to the big endianness in this configuration, so with the latter
> board dumps of arrays from SREC and hex formats are currently seen
> endian-reversed.
>
> 2007-07-24 Maciej W. Rozycki <macro@mips.com>
>
> * gdb.base/dump.exp: Force the correct endianness for binary
> formats not carrying this information.
>
> OK to apply?
This looks reasonable --- please apply it, if you've also tested it on
some desktop-like system.
Also, you should go ahead and add yourself at the proper point in the
"Write After Approval" section of gdb/MAINTAINERS, as a separate
commit, with a ChangeLog entry.