This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] Remove dead code in gdbtk/generic/gdbtk-stack.c
- From: Daniel Jacobowitz <drow at false dot org>
- To: Markus Deuling <deuling at de dot ibm dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Ulrich Weigand <uweigand at de dot ibm dot com>
- Date: Sun, 1 Jul 2007 18:32:48 -0400
- Subject: Re: [rfc] Remove dead code in gdbtk/generic/gdbtk-stack.c
- References: <467B7FB8.80100@de.ibm.com>
On Fri, Jun 22, 2007 at 09:52:24AM +0200, Markus Deuling wrote:
> Hi,
>
> in gdbtk/generic/gdbtk-stack.c is an occurence of macro PC_LOAD_SEGMENT which
> was deleted a long time
> ago. I guess the code inside the if #define/#endif is dead code. This patch
> removes it. I'm not sure how to test it :-)
>
>
> ChangeLog:
>
> * gdbtk/generic/gdbtk-stack.c (get_frame_name): Remove dead code
> (PC_LOAD_SEGMENT).
>
> Is this ok to commit?
Two things:
- PC_LOAD_SEGMENT is in gdbint, too. Could you remove it when you
have a chance?
- This patch is for Insight, so you should probably send it to the
Insight mailing list instead.
It looks fine to me though.
--
Daniel Jacobowitz
CodeSourcery