Re: [rfc] [2/6] Replace DEPRECATED_FUNCTION_START_OFFSET

["Ulrich Weigand" <uweigand at de dot ibm dot com>]

Eli Zaretskii wrote:
> > this patch replaces DEPRECATED_FUNCTION_START_OFFSET by gdbarch_deprecated_function_start_offset. 
> 
> Sorry if I'm missing something obvious (I didn't track this series of
> patches too closely), but what is the purpose and the advantages of
> replacing a deprecated macro with a deprecated function?

The purpose of this patch series is to make the "current_gdbarch" that is
implicit in those macros *explicit* at the call site, so that we can
subsequently replace it with the appropriate local "gdbarch" architecture.
This is all part of supporting multiple architectures at the same time.

Now, for those particular cases where the macro is already deprecated,
we might alternatively just eliminate its use.  However, for this specific
macro some thought is required how that can be done (if at all).  I thought
it made sense to follow through with eliminating all the gdbarch macros
now, even the deprecated ones.  They actual elimination of the deprecated
routines can happen later on just the same.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com