This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] Remove macro DEPRECATED_FUNCTION_START_OFFSET
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: deuling at de dot ibm dot com
- Cc: gdb-patches at sourceware dot org, uweigand at de dot ibm dot com
- Date: Fri, 15 Jun 2007 22:55:56 +0200 (CEST)
- Subject: Re: [rfc] Remove macro DEPRECATED_FUNCTION_START_OFFSET
- References: <46703FA7.1030707@de.ibm.com>
> Date: Wed, 13 Jun 2007 21:04:07 +0200
> From: Markus Deuling <deuling@de.ibm.com>
>
> Hello,
>
> this patch completely removes macro
> DEPRECATED_FUNCTION_START_OFFSET. This macro is deprecated and was
> replaced by gdbarch_convert_from_func_ptr_addr. Build and test on
> x86. Testsuite showed no regression.
>
> ChangeLog:
> * gdbarch.sh (DEPRECATED_FUNCTION_START_OFFSET): Remove.
> * cli/cli-cmds.ci (disassemble_command): Replace
> DEPRECATED_FUNCTION_START_OFFSET by gdbarch_convert_from_func_ptr_addr.
> * symtab.c (skip_prologue_using_sal,find_function_start_sal): Likewise.
> * linespec.c (minsym_found): Likewise.
> (target.h): New include.
> * infrun.c (handle_inferior_event): Likewise.
> * infcall.c (find_function_addr): Likewise.
> * Makefile.in (linespec.o): Update dependency to target.h.
> * gdbarch.c, gdbarch.h: Regenerate.
>
> Is this ok to commit?
Unfortunately it is not, since it breaks vax.
gdbarch_convert_from_func_ptr_addr() is not equivalent to
DEPRECATED_FUNCTION_START_OFFSET, since the former is applied in
places where the latter isn't.