This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[rfc/rfa] [1/4] SPU enhancements: preparation
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: gdb-patches at sourceware dot org
- Date: Sat, 2 Jun 2007 21:31:11 +0200 (CEST)
- Subject: [rfc/rfa] [1/4] SPU enhancements: preparation
Hello,
this is a small fix in preparation for adding extended SPU query support.
Some files in spufs accessed via the spu_proc_xfer_spu routines in
spu-linux-nat.c and gdbserver/spu-low.c are non-seekable. Currently,
any attempt to access those at non-zero offset results in a failure.
However, that is a problem when trying to use those files via the
target object mechanism. For example, the target_read routine will
first read a chunk at offset zero (which succeeds, and in fact is
generally sufficient to retrieve the full contents as the non-seekable
files are small). But then it attempts a second read at an offset
corresponding to the length of the first chunk read, which now fails.
This patch changes spu_proc_xfer_spu to simply return zero (i.e. no
more data available) on any attempt to access a non-seekable spufs
file at non-zero offset.
Tested on spu-elf in conjunction with the other patches.
Bye,
Ulrich
ChangeLog:
* spu-linux-nat.c (spu_proc_xfer_spu): Do not return failure when
accessing non-seekable spufs files.
gdbserver/ChangeLog:
* spu-low.c (spu_proc_xfer_spu): Do not return failure when
accessing non-seekable spufs files.
diff -urNp gdb-orig/gdb/gdbserver/spu-low.c gdb-head/gdb/gdbserver/spu-low.c
--- gdb-orig/gdb/gdbserver/spu-low.c 2007-05-10 23:34:34.000000000 +0200
+++ gdb-head/gdb/gdbserver/spu-low.c 2007-06-01 19:21:10.212694495 +0200
@@ -248,7 +248,7 @@ spu_proc_xfer_spu (const char *annex, un
&& lseek (fd, (off_t) offset, SEEK_SET) != (off_t) offset)
{
close (fd);
- return -1;
+ return 0;
}
if (writebuf)
diff -urNp gdb-orig/gdb/spu-linux-nat.c gdb-head/gdb/spu-linux-nat.c
--- gdb-orig/gdb/spu-linux-nat.c 2007-05-09 01:01:49.000000000 +0200
+++ gdb-head/gdb/spu-linux-nat.c 2007-06-01 19:21:10.362672892 +0200
@@ -250,7 +250,7 @@ spu_proc_xfer_spu (const char *annex, gd
&& lseek (fd, (off_t) offset, SEEK_SET) != (off_t) offset)
{
close (fd);
- return -1;
+ return 0;
}
if (writebuf)
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com