This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: ser-unix.c: Add hardware flow control support


On Fri, Mar 30, 2007 at 12:54:50PM +0100, Maciej W. Rozycki wrote:
> Hello,
> 
>  This is a set of changes to add hardware flow control support to the 
> serial interface.
> 
> 2007-03-30  Chris Dearman  <chris@mips.com>
>             Maciej W. Rozycki  <macro@mips.com>
> 
> 	* ser-unix.c (show_serial_hwflow): New function.
> 	(hardwire_raw): Add hardware flow control support.
> 	(_initialize_ser_hardwire): Add set/show remoteflow.
> 
>  OK to apply?

At a minimum this will require documentation for the new command line
option; I would also recomend a NEWS entry.  Oh, and you added a
#include, so you need a Makefile update too.

I noticed while looking for the right place to put the option that we
have an empty "set serial".  Perhaps it should go under that instead.
No strong preference.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]