This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: "target remote | " stderr
- From: Vladimir Prus <ghost at cs dot msu dot su>
- To: Eli Zaretskii <eliz at gnu dot org>, gdb-patches at sources dot redhat dot com
- Date: Sat, 17 Feb 2007 10:34:36 +0300
- Subject: Re: "target remote | " stderr
- References: <200701261653.53834.vladimir@codesourcery.com> <20070126140028.GA29456@nevyn.them.org> <epq9dd$k4s$1@sea.gmane.org> <20070131144101.GA23780@nevyn.them.org> <eqnhq8$8nt$1@sea.gmane.org> <uire85tq7.fsf@gnu.org>
Eli Zaretskii wrote:
>> From: Vladimir Prus <ghost@cs.msu.su>
>> Date: Sun, 11 Feb 2007 19:55:03 +0300
>>
>> --- gdb/serial.h (/mirrors/gdb_mainline) (revision 3417)
>> +++ gdb/serial.h (/patches/gdb/remote_stderr_try2/gdb_mainline) (revision
>> 3417) @@ -191,6 +191,12 @@ extern int serial_debug_p (struct serial
>> struct serial
>> {
>> int fd; /* File descriptor */
>> + int error_fd; /* File descriptor for a separate
>> + error stream that should be
>> + immediately forwarded to gdb_stderr.
>> + This may be -1.
>> + If != -1, this descriptor should
>> + be non-blocking. */
>
> This comment isn't according to GNU coding standards, I think.
Can you please be more specific?
>> +#ifdef _WIN32
>
> Won't this catch Cygwin as well? Do we want that?
I would hope this won't catch cygwin, but I don't know. I'll check.
- Volodya