This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] varobj deletion after the binary has changed
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Nick Roberts <nickrob at snap dot net dot nz>
- Cc: drow at false dot org, denis dot pilat at st dot com, gdb-patches at sourceware dot org
- Date: Fri, 09 Feb 2007 17:43:39 +0200
- Subject: Re: [RFC] varobj deletion after the binary has changed
- References: <20070123124457.GA1600@nevyn.them.org> <45B63A49.4010609@st.com> <45B8E8A8.9040904@st.com> <17849.12231.246980.478169@kahikatea.snap.net.nz> <20070125232731.GA30178@nevyn.them.org> <45BDEAEC.1050006@st.com> <17854.28971.170898.231523@kahikatea.snap.net.nz> <45C0B042.9040308@st.com> <17857.2617.164646.935952@kahikatea.snap.net.nz> <45C1B78C.60605@st.com> <20070208164103.GA13544@nevyn.them.org> <17867.31476.627368.180759@kahikatea.snap.net.nz>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Nick Roberts <nickrob@snap.net.nz>
> Date: Fri, 9 Feb 2007 08:33:08 +1300
> Cc: Denis PILAT <denis.pilat@st.com>, gdb-patches <gdb-patches@sourceware.org>
>
> How about this?
Approved, provided that you fix the following:
> + @item
> + The range of values for fields with specified values e.g in_scope,
> + type_changed may be extended.
First, "e.g" lacks the second period and a comma after it ("e.g.,").
Second, in_scope and type_changed should be in @code or @samp.
Third, these two are not mentioned anywhere in the node you are
patching, so please either add a cross-reference to where they are
described or add some minimal description to the text.
> Reevaluate the expressions corresponding to the variable object
> @var{name} and all its direct and indirect children, and return the
> ! list of variable objects whose values have changed. @var{name} must
> ! be a root variable object.
The last sentence will begin with a non-capital letter, which is not
valid English. How about using `;' instead of a period before
@var{name}?
Thanks.