This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/ada] Improve is_known_support_routine
- From: Daniel Jacobowitz <drow at false dot org>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 7 Jan 2007 18:38:32 -0500
- Subject: Re: [RFA/ada] Improve is_known_support_routine
- References: <20070106182652.GR15512@adacore.com>
On Sat, Jan 06, 2007 at 10:26:52PM +0400, Joel Brobecker wrote:
> The is_known_support_routine identifies any frame for which we cannot
> find the source file. The check we currently have in place is a bit too
> simplistic, so I replaced it with the function we use to locate source
> files:
>
> - if (stat (sal.symtab->filename, &st))
> + if (symtab_to_fullname (sal.symtab) == NULL)
Fine with me, although I wonder if "the source is missing" is really
the concept you want. Why should whether source for the runtime
library is present determine what we show? That would make the
feature more awkward to use for people who built their own libgnat and
still have the build tree.
Anyway, OK meanwhile.
--
Daniel Jacobowitz
CodeSourcery