This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Cleanup varobj children handling
On Friday 22 December 2006 09:44, Nick Roberts wrote:
> > > /* Every variable keeps a linked list of its children, described
> > > by the following structure. */
> > > /* FIXME: Deprecated. All should use vlist instead */
> > >
> > > Buy perhaps this is not relevant.
> >
> > The comment was written before vec.c was available, so it naturally
> > does not suggest vec.c.
>
> Before your change varobj.c had two (equivalent?) types of data structure:
> vstack and vlist.
Actually, three: vstack, varobj_child and vlist.
> After your change varobj.c has two (equivalent?) types of
> data structure: VEC and vlist.
That's one data type off, plus vec.h is generic code, not private to varobj.c
> Should VEC not also be used for vlist?
Ultimately, yes. But I primarily wanted to cleanup the list of children, so open
path for other changes.
vlist does not get in my way, yet ;-)
- Volodya