This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFA] gdbserver/server.c: Replace 2x strlen() by a variable
- From: Markus Deuling <deuling at de dot ibm dot com>
- To: GDB Patches <gdb-patches at sourceware dot org>
- Date: Thu, 21 Dec 2006 08:44:44 +0100
- Subject: [RFA] gdbserver/server.c: Replace 2x strlen() by a variable
Hello,
this little patch adds a variable to prevent strlen() from being called two times.
Maybe it would also be a good idea to replace it by the hard-coded length, but I think
the code then will be less readable then.
Is it ok to apply ?
ChangeLog:
* server.c (handle_general_set): New variable len instead
of using strlen two times.
=========================================
diff -urN src/gdb/gdbserver/server.c dev/gdb/gdbserver/server.c
--- src/gdb/gdbserver/server.c 2006-12-21 08:38:11.000000000 +0100
+++ dev/gdb/gdbserver/server.c 2006-12-21 08:38:25.000000000 +0100
@@ -163,10 +163,11 @@
void
handle_general_set (char *own_buf)
{
- if (strncmp ("QPassSignals:", own_buf, strlen ("QPassSignals:")) == 0)
+ int len = strlen ("QPassSignals:");
+ if (strncmp ("QPassSignals:", own_buf, len) == 0)
{
int numsigs = (int) TARGET_SIGNAL_LAST, i;
- const char *p = own_buf + strlen ("QPassSignals:");
+ const char *p = own_buf + len;
CORE_ADDR cursig;
p = decode_address_to_semicolon (&cursig, p);
Regards,
Markus
--
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com