This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: "Transfer rate" patch
- From: Michael Snyder <Michael dot Snyder at palmsource dot com>
- To: Ilko Iliev <office at ronetix dot at>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 05 Sep 2006 11:03:43 -0700
- Subject: Re: "Transfer rate" patch
- References: <44FD2640.7080605@ronetix.at>
On Tue, 2006-09-05 at 09:24 +0200, Ilko Iliev wrote:
> Hi,
>
> I found a small bug by the calculating of the transfer rate at the
> "load" command - if the download image size or the download speed is
> higher then occurs overflow and the printed information is wrong.
>
> I attached a patch for this problem.
Thank you Ilko -- two requests.
1) The gnu coding standard calls for a white space on each side
of an operator, eg. not "(foo)*1000" but (foo) * 1000". Could
you add those please? If you need to break a long line, break
it at an operator, and put the operator on the new line. And,
2) All patches require a ChangeLog entry. It should be short
and descriptive, eg. "Fixed overflow problem". See the file,
ChangeLog, to get the format, and please include an entry when
you re-submit.
Thanks,
Michael Snyder