This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] set/unset/show substitute-path commands (take 2)
On Mon, Jul 17, 2006 at 10:09:33AM -0700, Joel Brobecker wrote:
> > >+ /* Otherwise, skip to the last rule in our list and then append
> > >+ the new rule. */
> > >+
> > >+ last = substitute_path_rules;
> > >+ while (last->next != NULL)
> > >+ last = last->next;
> > >+
> > >+ last->next = rule;
> >
> > What if the user tries to substitute the same path twice? I think it
> > should delete the old rule (maybe query) and add the new one to the end.
>
> I think we are getting dragged into over-engineering this feature.
> If documentation is clear enough that it just adds, then he knows
> he has to remove the previous rule before he introduces the new one.
> That's plenty good enough in my opinion.
I'm inclined to agree with Andrew on both points he raised.
After that though, you're right - we're dragging this on too long. If
you'll repost it with those two changes I will be sure to review it
today.
--
Daniel Jacobowitz
CodeSourcery