This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Testsuite failures
- From: Nick Roberts <nickrob at snap dot net dot nz>
- To: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 17 Jul 2006 00:37:05 +1200
- Subject: Re: Testsuite failures
- References: <200607161142.k6GBgPGf020488@elgar.sibelius.xs4all.nl>
> I'm seeing some new testsuite failures on several OpenBSD machines:
>
> Running ../../../../src/gdb/gdb/testsuite/gdb.base/annota3.exp ...
> FAIL: gdb.base/annota3.exp: run until main breakpoint (pattern 6)
> FAIL: gdb.base/annota3.exp: send SIGUSR1 (pattern 5)
> FAIL: gdb.base/annota3.exp: annotate ignore count change (pattern 3)
>
> I think these are caused by your last commit:
>
> 2006-07-13 Nick Roberts <nickrob@snap.net.nz>
>
> * annotate.c (annotate_frame_begin): Re-instate frame-begin
> annotation for level 3 annotations.
Yes. I forgot that there were tests for level 3 annotations. Sorry about
that.
> Here's a patch that adjusts the testsuite to deal with the re-instated
> frame-begin annotation. Can you verify that this is indeed the
> intended effect of your change?
It looks good to me. Also annota3.exp in gdb.cp (patch attached). It might
be easier to use the $hex variable but I couldn't get it to work.
> Index: ChangeLog
> from Mark Kettenis <kettenis@gnu.org>
>
> * gdb.base/annota3.exp: Adjust patterns for re-instated
> frame-begin annotation.
>
> Index: gdb.base/annota3.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/annota3.exp,v
> retrieving revision 1.7
> diff -u -p -r1.7 annota3.exp
> --- gdb.base/annota3.exp 7 Mar 2006 15:23:32 -0000 1.7
> +++ gdb.base/annota3.exp 16 Jul 2006 11:41:02 -0000
> @@ -112,6 +112,7 @@ gdb_expect_list "breakpoint info" "$gdb_
>
> #
> # run to a break point will test:
> +# annotate-frame-begin
I don't think this comment should be added (it means nothing to me).
> #exp_internal 1
>...
--
Nick http://www.inet.net.nz/~nickrob
*** annota3.exp 12 Mar 2006 19:42:40 +1300 1.5
--- annota3.exp 17 Jul 2006 00:20:54 +1200
*************** gdb_expect_list "first run until main br
*** 96,102 ****
"\r\n\032\032starting\r\n"
"\r\n\032\032breakpoint 1\r\n"
"\r\n"
! "Breakpoint 1, main \\(\\) at .*annota3.cc:25\r\n"
"\r\n\032\032source.*annota3.cc:25:.*:beg:0x\[0-9a-z\]+\r\n"
"\r\n\032\032stopped\r\n"
}
--- 96,104 ----
"\r\n\032\032starting\r\n"
"\r\n\032\032breakpoint 1\r\n"
"\r\n"
! "Breakpoint 1, "
! "\r\n\032\032frame-begin 0 0x\[0-9a-z\]+\r\n"
! "main \\(\\) at .*annota3.cc:25\r\n"
"\r\n\032\032source.*annota3.cc:25:.*:beg:0x\[0-9a-z\]+\r\n"
"\r\n\032\032stopped\r\n"
}
*************** gdb_expect_list "second run until main b
*** 164,170 ****
"\r\n\032\032starting\r\n"
"\r\n\032\032breakpoint 2\r\n"
"\r\n"
! "Breakpoint 2, main \\(\\) at .*annota3.cc:22\r\n"
"\r\n\032\032source.*annota3.cc:22:.*:beg:0x\[0-9a-z\]+\r\n"
"\r\n\032\032stopped\r\n"
}
--- 166,174 ----
"\r\n\032\032starting\r\n"
"\r\n\032\032breakpoint 2\r\n"
"\r\n"
! "Breakpoint 2, "
! "\r\n\032\032frame-begin 0 0x\[0-9a-z\]+\r\n"
! "main \\(\\) at .*annota3.cc:22\r\n"
"\r\n\032\032source.*annota3.cc:22:.*:beg:0x\[0-9a-z\]+\r\n"
"\r\n\032\032stopped\r\n"
}