This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Crashed cross gdb/MinGW host
- From: Christopher Faylor <me at cgf dot cx>
- To: Masaki Muranaka <monaka at monami-software dot com>, gdb-patches at sourceware dot org
- Date: Sat, 10 Jun 2006 16:41:33 -0400
- Subject: Re: [patch] Crashed cross gdb/MinGW host
- References: <0494AFF8-AB9B-40E8-A4D2-C119DEEC5248@monami-software.com> <20060519185257.GA2667@trixie.casa.cgf.cx> <20060610182507.GA802@nevyn.them.org>
On Sat, Jun 10, 2006 at 02:25:07PM -0400, Daniel Jacobowitz wrote:
>On Fri, May 19, 2006 at 02:52:57PM -0400, Christopher Faylor wrote:
>> On Fri, May 19, 2006 at 06:47:04PM +0900, Masaki Muranaka wrote:
>> >My sh-elf-gdb on MinGW host was crashed when I tried to debug using the
>> >serial connection. Here is a patch.
>> >
>> >It's possible the another plan to remove writefds check. There is no
>> >support yet for writefds.
>>
>> If this is truly supposed to be an emulation of the system select(), I
>> think it would make sense to check both !readfds and !writefds.
>
>Sorry for letting this sit so long. I just encountered this bug today.
>I think I tested console and pipe when I last touched this code
>but failed to test ser-base.
>
>The underlying problem is actually different. The code looks like
>this:
> if (!FD_ISSET (fd, readfds) && !FD_ISSET (fd, writefds))
> continue;
>
> if (FD_ISSET (fd, readfds))
> ...
>
> if (FD_ISSET (fd, exceptfds))
> ...
>
>See the mismatch? :-(
I saw it and was wondering about it. I'm glad to see consistency restored.
:-)
cgf