This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Omit environment dependent hex values in testsuite results


Having the gdb testsuite results include hex values that are dependent
on the specific hardware or software environment at runtime makes
comparing results of different testsuite runs more difficult and they
don't really add any useful information to passing results.

Here is an example of the outputs before and after applying the patch:

    < Test Run By fnf on Sun Feb 19 09:39:25 2006
    ---
    > Test Run By fnf on Sun Feb 19 10:04:57 2006
    3760,3761c3758,3759
    < PASS: gdb.base/pc-fp.exp: get value of $pc (0x80483c4)
    < PASS: gdb.base/pc-fp.exp: get value of $fp (0xbfd00d28)
    ---
    > PASS: gdb.base/pc-fp.exp: get value of $pc
    > PASS: gdb.base/pc-fp.exp: get value of $fp
    5477c5475
    < PASS: gdb.base/shreloc.exp: get_msym_addrs static_var_[12] (0x2fa640 0x112640)
    ---
    > PASS: gdb.base/shreloc.exp: get_msym_addrs static_var_[12]
    5479c5477
    < PASS: gdb.base/shreloc.exp: get_msym_addrs extern_var_[12] (0x8049774 0x8049778 0x2fa63c 0x11263c)
    ---
    > PASS: gdb.base/shreloc.exp: get_msym_addrs extern_var_[12]
    5481c5479
    < PASS: gdb.base/shreloc.exp: get_msym_addrs fn_[12] (0x2f94bc 0x1114bc)
    ---
    > PASS: gdb.base/shreloc.exp: get_msym_addrs fn_[12]

-Fred

@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@

2006-02-19  Fred Fish  <fnf@specifix.com>

	* gdb.base/pc-fp.exp (get_valueofx): Don't print environment
	specifix hex value as part of results.
	* gdb.base/shreloc.exp (get_msym_addrs): Ditto.
	
Index: testsuite/gdb.base/pc-fp.exp
===================================================================
RCS file: /cvsroots/latest/src/gdb/gdb/testsuite/gdb.base/pc-fp.exp,v
retrieving revision 1.1.1.1
diff -c -p -r1.1.1.1 pc-fp.exp
*** testsuite/gdb.base/pc-fp.exp	8 Oct 2005 19:36:19 -0000	1.1.1.1
--- testsuite/gdb.base/pc-fp.exp	19 Feb 2006 15:04:43 -0000
*************** proc get_valueofx { fmt exp default } {
*** 62,68 ****
      gdb_expect {
  	-re "\\$\[0-9\]* = (0x\[0-9a-zA-Z\]+).*$gdb_prompt $" {
  	    set val $expect_out(1,string)
! 	    pass "get value of ${exp} ($val)"
  	}
  	timeout {
  	    set val ${default}
--- 62,68 ----
      gdb_expect {
  	-re "\\$\[0-9\]* = (0x\[0-9a-zA-Z\]+).*$gdb_prompt $" {
  	    set val $expect_out(1,string)
! 	    pass "get value of ${exp}"
  	}
  	timeout {
  	    set val ${default}
Index: testsuite/gdb.base/shreloc.exp
===================================================================
RCS file: /cvsroots/latest/src/gdb/gdb/testsuite/gdb.base/shreloc.exp,v
retrieving revision 1.1.1.1
diff -c -p -r1.1.1.1 shreloc.exp
*** testsuite/gdb.base/shreloc.exp	8 Oct 2005 19:36:19 -0000	1.1.1.1
--- testsuite/gdb.base/shreloc.exp	19 Feb 2006 15:04:43 -0000
*************** proc get_msym_addrs { var msymfile } {
*** 191,197 ****
  	    }
  
  	    -re "$gdb_prompt $" {
! 		pass "get_msym_addrs ${var} (${result})"
  		return "${result}"
  	    }
  
--- 191,197 ----
  	    }
  
  	    -re "$gdb_prompt $" {
! 		pass "get_msym_addrs ${var}"
  		return "${result}"
  	    }
  


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]