This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] fix build failure on ppc-aix
- From: Daniel Jacobowitz <drow at false dot org>
- To: gdb-patches at sourceware dot org
- Date: Fri, 27 Jan 2006 14:40:32 -0500
- Subject: Re: [RFA] fix build failure on ppc-aix
- References: <20060127193132.GF1203@adacore.com>
On Fri, Jan 27, 2006 at 02:31:32PM -0500, Joel Brobecker wrote:
> Hello,
>
> GDB stopped building after the fix for PR gdb/1914 was checked in.
> It's a tiny copy/paste issue, where a variable used in the call to
> the LIB_CREATE_INFERIOR_HOOK is not available in the context where
> the code has been moved to.
>
> I think the attached patch provides the appropriate fix. I don't
> see any other way to get the pid. I looked at the code, and it
> seems to me that inferior_ptid will always be set at that point.
> The only case when I wasn't completely sure is in corelow. But
> I don't think that the solib code would be affected in that case
> if the PID wasn't set. Would it?
>
> 2006-01-27 Joel Brobecker <brobecker@adacore.com>
>
> * infcmd.c (post_create_inferior): Fix copy/paste error introduced
> in the previous change.
>
> Fixes the build on ppc-aix. I also ran the testsuite out of curiosity.
> The results are fair for this platform.
Wow, the xcoff solib code is a mess; I doubt it works right with
corefiles at all, since if this gets called, it's going to do ptrace
ops. But your patch is fine.
--
Daniel Jacobowitz
CodeSourcery