This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix ptype problem printing typedefs defined differently in different compilation units


On Wed, Jan 04, 2006 at 04:04:49PM -0500, Fred Fish wrote:
> On Tuesday 03 January 2006 22:45, Jim Blandy wrote:
> 
> > what would break if parse_exp_in_context used the current source
> > position as a fallback when get_selected_block returns zero?  It
> > seems reasonable to me.
> 
> That seems like the most reasonable alternative to me as well.  The
> following patch solves the same problem as the original patch, in what
> is probably a little cleaner way.  I don't get any testsuite
> regressions when using it.
> 
> -Fred
> 
> 2006-01-04  Fred Fish  <fnf@fishfood.ninemoons.com>
> 
> 	* parse.c (source.h): Include.
> 	(parse_exp_in_context):  Use static source context if no
> 	other context found.

Given the followups, I think this patch is OK.  Jim, do you agree?

(Since we currently have new, failing tests...)

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]