This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fully anchor mi_gdb_test expected results.


On Sun, Sep 25, 2005 at 09:42:18PM -0400, Daniel Jacobowitz wrote:
> On Tue, Sep 20, 2005 at 09:25:39PM -0400, Bob Rossi wrote:
> > This has gone away in the new patch, tell me what you think. I had to
> > modify several testcases, but only to get them to match the begin
> > anchor. This of course passes the testsuite. 
> > 
> > With this change I think I'm only several lines away from syntax
> > checking the testsuite. I'll try it out to see if anything's changed
> > recently.
> > 
> > Bob Rossi
> > 
> > RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v
> > +2005-08-03  Bob Rossi  <bob@brasko.net>
> > +
> > +	* gdb.mi/mi-disassemble.exp, gdb.mi/mi2-disassemble.exp: Remove .* 
> > +	from test.  Escape the | in mi_gdb_test call.
> > +	* gdb.mi/mi-basics.exp, gdb.mi/mi-cli.exp, gdb.mi/mi-disassemble.exp,
> > +	gdb.mi/mi-pthreads.exp, gdb.mi/mi-stack.exp, gdb.mi/mi2-basics.exp,
> > +	gdb.mi/mi2-cli.exp, gdb.mi/mi2-disassemble.exp,
> > +	gdb.mi/mi2-pthreads.exp, gdb.mi/mi2-stack.exp: Add extra details to
> > +	expected regex's in mi_gdb_test calls.
> > +	* lib/mi-support.exp: Remove arbitrary .* from tests.
> > +	(mi_gdb_test): Add string_regex variable. Add anchor to main -re.
> > +	Fully anchor GDB/MI expected results in mi_gdb_test.
> > +	* lib/gdb.exp (string_to_regexp): Escape the ] character.
> > +	* gdb.base/sizeof.exp: Remove escape character. Correct test.
> 
> Looks good to me.  This is OK.  Could you make sure to update the
> copyright years in any of these files which weren't changed in 2005? 
> Only one I see offhand is sizeof.exp but I did not check them all.

Thanks Daniel, I appreciate it. I added the copyright dates and
committed the patch. Also, I thought it might be nice to hear, the
MI is still syntactically correct!

This means I can continue nicely, without any distractions at this
point.

Thanks,
Bob Rossi


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]