This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: ppc32 debugging ppc64, part 1


On Sat, Sep 17, 2005 at 07:01:23PM -0700, Richard Henderson wrote:
> On Sat, Sep 17, 2005 at 05:24:03PM -0400, Daniel Jacobowitz wrote:
> > You don't need this; PTRACE_TYPE_RET should work OK.  We get that from
> > autoconf (even if the autoconf bits are a bit broken on Linux at the
> > moment, they'll choose long anyway).
> 
> I've purged PTRACE_XFER_TYPE from the file entirely.

Thanks.

> > I think it's safe to do away with the syscalls; the current userspace
> > ptrace interface where glibc has to special-case PEEKTEXT/PEEKDATA/PEEKUSER
> > is nasty enough, so I'm willing to declare glibc broken if it is ever
> > "fixed" to handle the PEEK*_3264 operations specially.
> 
> What about the argument that it causes source uglification because
> PEEKUSER and PEEKUSER_3464 have different calling sequences in the
> libc funtion, but not the syscall?
> 
> For the record, my current source follows.
> 
> I'll get rid of the use of the syscall if required, but my 2 cents
> say it looks cleaner this way.

Yes, that's a more compelling argument.  Works for me.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]