This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: Patch for gdb/configure cleanup (autoheader warnings)
- From: Steve Ellcey <sje at cup dot hp dot com>
- To: drow at false dot org
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 3 Jul 2005 08:33:37 -0700 (PDT)
- Subject: Re: Patch for gdb/configure cleanup (autoheader warnings)
> You've lost half your changelog entry :-)
>
> Also, I notice you're converting XM_FILE. It's dead; there are no sets
> of it any more. Someone should go through and purge the remaining bits
> of it soon...
>
> --
> Daniel Jacobowitz
> CodeSourcery, LLC
OK, here is the patch again with the changelog file updated (all I added
was the comment after 'configure.ac:'. There are too many AC_DEFINE
statments changed to list them all. There were no changes to
configure.ac other than adding the 2nd and 3rd arguments to the
AC_DEFINE calls.
As for XM_FILE, I am willing to kill it, but I would rather do that in a
separate patch so why don't I leave it here and I can then do a new
patch to remove it completely from the various config, header, and C
files.
Steve Ellcey
sje@cup.hp.com
gdb/ChangeLog
2005-07-01 Steve Ellcey <sje@cup.hp.com>
* configure.ac (AC_DEFINE): Add args to AC_DEFINE calls.
* acconfig.h: Remove file.
* acinclude.m4 (AC_GNU_SOURCE): Remove definition.
* configure: Regenerate.
* config.in: Regenerate.
*** src.orig/gdb/acinclude.m4 Fri Jul 1 16:01:27 2005
--- src/gdb/acinclude.m4 Fri Jul 1 16:01:06 2005
*************** size_t iconv();
*** 920,934 ****
AC_SUBST(LIBICONV)
])
- # AC_GNU_SOURCE
- # -------------
- # FIXME: Remove thise once we start using Autoconf 2.5x (x>=4).
- AC_DEFUN([AC_GNU_SOURCE],
- [AC_BEFORE([$0], [AC_TRY_COMPILE])dnl
- AC_BEFORE([$0], [AC_TRY_RUN])dnl
- AC_DEFINE([_GNU_SOURCE])
- ])
-
dnl written by Guido Draheim <guidod@gmx.de>, original by Alexandre Oliva
dnl Version 1.3 (2001/03/02)
dnl source http://www.gnu.org/software/ac-archive/Miscellaneous/ac_define_dir.html
--- 920,925 ----
*** src.orig/gdb/configure.ac Fri Jul 1 16:01:27 2005
--- src/gdb/configure.ac Fri Jul 1 16:02:46 2005
*************** esac],[
*** 224,230 ****
if test x"$enable_libunwind" = xyes; then
AC_CHECK_HEADERS(libunwind.h)
AC_CHECK_HEADERS(libunwind-ia64.h)
! AC_DEFINE(HAVE_LIBUNWIND, 1)
CONFIG_OBS="$CONFIG_OBS libunwind-frame.o"
CONFIG_DEPS="$CONFIG_DEPS libunwind-frame.o"
CONFIG_SRCS="$CONFIG_SRCS libunwind-frame.c"
--- 224,230 ----
if test x"$enable_libunwind" = xyes; then
AC_CHECK_HEADERS(libunwind.h)
AC_CHECK_HEADERS(libunwind-ia64.h)
! AC_DEFINE(HAVE_LIBUNWIND, 1, [Define if libunwind library is being used.])
CONFIG_OBS="$CONFIG_OBS libunwind-frame.o"
CONFIG_DEPS="$CONFIG_DEPS libunwind-frame.o"
CONFIG_SRCS="$CONFIG_SRCS libunwind-frame.c"
*************** AC_CACHE_VAL(gdb_cv_have_ptrace_getregs,
*** 628,634 ****
[gdb_cv_have_ptrace_getregs=no])])
AC_MSG_RESULT($gdb_cv_have_ptrace_getregs)
if test $gdb_cv_have_ptrace_getregs = yes; then
! AC_DEFINE(HAVE_PTRACE_GETREGS)
fi
# See if <sys/ptrace.h> provides the PTRACE_GETFPXREGS request.
--- 628,635 ----
[gdb_cv_have_ptrace_getregs=no])])
AC_MSG_RESULT($gdb_cv_have_ptrace_getregs)
if test $gdb_cv_have_ptrace_getregs = yes; then
! AC_DEFINE(HAVE_PTRACE_GETREGS, 1,
! [Define if sys/ptrace.h defines the PTRACE_GETREGS request.])
fi
# See if <sys/ptrace.h> provides the PTRACE_GETFPXREGS request.
*************** AC_CACHE_VAL(gdb_cv_have_ptrace_getfpxre
*** 640,646 ****
[gdb_cv_have_ptrace_getfpxregs=no])])
AC_MSG_RESULT($gdb_cv_have_ptrace_getfpxregs)
if test $gdb_cv_have_ptrace_getfpxregs = yes; then
! AC_DEFINE(HAVE_PTRACE_GETFPXREGS)
fi
# See if <sys/ptrace.h> provides the PT_GETDBREGS request.
--- 641,648 ----
[gdb_cv_have_ptrace_getfpxregs=no])])
AC_MSG_RESULT($gdb_cv_have_ptrace_getfpxregs)
if test $gdb_cv_have_ptrace_getfpxregs = yes; then
! AC_DEFINE(HAVE_PTRACE_GETFPXREGS, 1,
! [Define if sys/ptrace.h defines the PTRACE_GETFPXREGS request.])
fi
# See if <sys/ptrace.h> provides the PT_GETDBREGS request.
*************** AC_CACHE_VAL(gdb_cv_have_pt_getdbregs,
*** 653,659 ****
[gdb_cv_have_pt_getdbregs=no])])
AC_MSG_RESULT($gdb_cv_have_pt_getdbregs)
if test $gdb_cv_have_pt_getdbregs = yes; then
! AC_DEFINE(HAVE_PT_GETDBREGS)
fi
# See if <sys/ptrace.h> provides the PT_GETXMMREGS request.
--- 655,662 ----
[gdb_cv_have_pt_getdbregs=no])])
AC_MSG_RESULT($gdb_cv_have_pt_getdbregs)
if test $gdb_cv_have_pt_getdbregs = yes; then
! AC_DEFINE(HAVE_PT_GETDBREGS, 1,
! [Define if sys/ptrace.h defines the PT_GETDBREGS request.])
fi
# See if <sys/ptrace.h> provides the PT_GETXMMREGS request.
*************** AC_CACHE_VAL(gdb_cv_have_pt_getxmmregs,
*** 666,672 ****
[gdb_cv_have_pt_getxmmregs=no])])
AC_MSG_RESULT($gdb_cv_have_pt_getxmmregs)
if test $gdb_cv_have_pt_getxmmregs = yes; then
! AC_DEFINE(HAVE_PT_GETXMMREGS)
fi
# If we are configured native on GNU/Linux, work around problems with
--- 669,676 ----
[gdb_cv_have_pt_getxmmregs=no])])
AC_MSG_RESULT($gdb_cv_have_pt_getxmmregs)
if test $gdb_cv_have_pt_getxmmregs = yes; then
! AC_DEFINE(HAVE_PT_GETXMMREGS, 1,
! [Define if sys/ptrace.h defines the PT_GETXMMREGS request.])
fi
# If we are configured native on GNU/Linux, work around problems with
*************** fi
*** 676,693 ****
if test "${target}" = "${host}"; then
case "${host}" in
i[[3456]]86-*-linux*)
! AC_DEFINE(START_INFERIOR_TRAPS_EXPECTED,2)
! AC_DEFINE(sys_quotactl)
;;
*-*-unixware* | *-*-sysv4.2* | *-*-sysv5* | *-*-interix* )
! AC_DEFINE(NEW_PROC_API)
;;
*-*-solaris2.[[6789]] | *-*-solaris2.1[[0-9]])
! AC_DEFINE(NEW_PROC_API)
;;
mips-sgi-irix5*)
# Work around <sys/proc.h> needing _KMEMUSER problem on IRIX 5.
! AC_DEFINE([_KMEMUSER], 1)
;;
esac
fi
--- 680,705 ----
if test "${target}" = "${host}"; then
case "${host}" in
i[[3456]]86-*-linux*)
! AC_DEFINE(START_INFERIOR_TRAPS_EXPECTED, 2,
! [Define on a GNU/Linux system to work around problems in sys/procfs.h.])
! AC_DEFINE(sys_quotactl, 1,
! [Define on a GNU/Linux system to work around problems in sys/procfs.h.])
;;
*-*-unixware* | *-*-sysv4.2* | *-*-sysv5* | *-*-interix* )
! AC_DEFINE(NEW_PROC_API, 1,
! [Define if you want to use new multi-fd /proc interface
! (replaces HAVE_MULTIPLE_PROC_FDS as well as other macros).])
;;
*-*-solaris2.[[6789]] | *-*-solaris2.1[[0-9]])
! AC_DEFINE(NEW_PROC_API, 1,
! [Define if you want to use new multi-fd /proc interface
! (replaces HAVE_MULTIPLE_PROC_FDS as well as other macros).])
;;
mips-sgi-irix5*)
# Work around <sys/proc.h> needing _KMEMUSER problem on IRIX 5.
! AC_DEFINE([_KMEMUSER], 1,
! [Define to 1 so <sys/proc.h> gets a definition of anon_hdl. Works
! around a <sys/proc.h> problem on IRIX 5.])
;;
esac
fi
*************** if test "$ac_cv_header_sys_procfs_h" = y
*** 731,737 ****
gdb_cv_prfpregset_t_broken=yes)])
AC_MSG_RESULT($gdb_cv_prfpregset_t_broken)
if test $gdb_cv_prfpregset_t_broken = yes; then
! AC_DEFINE(PRFPREGSET_T_BROKEN)
fi
fi
--- 743,750 ----
gdb_cv_prfpregset_t_broken=yes)])
AC_MSG_RESULT($gdb_cv_prfpregset_t_broken)
if test $gdb_cv_prfpregset_t_broken = yes; then
! AC_DEFINE(PRFPREGSET_T_BROKEN, 1,
! [Define if the prfpregset_t type is broken.])
fi
fi
*************** if test "$ac_cv_header_sys_procfs_h" = y
*** 749,755 ****
gdb_cv_have_procfs_piocset=yes, gdb_cv_have_procfs_piocset=no)])
AC_MSG_RESULT($gdb_cv_have_procfs_piocset)
if test $gdb_cv_have_procfs_piocset = yes; then
! AC_DEFINE(HAVE_PROCFS_PIOCSET)
fi
fi
--- 762,769 ----
gdb_cv_have_procfs_piocset=yes, gdb_cv_have_procfs_piocset=no)])
AC_MSG_RESULT($gdb_cv_have_procfs_piocset)
if test $gdb_cv_have_procfs_piocset = yes; then
! AC_DEFINE(HAVE_PROCFS_PIOCSET, 1,
! [Define if ioctl argument PIOCSET is available.])
fi
fi
*************** if test ${host} = ${target} ; then
*** 767,773 ****
gdb_cv_have_struct_link_map_with_l_members=no)])
AC_MSG_RESULT($gdb_cv_have_struct_link_map_with_l_members)
if test $gdb_cv_have_struct_link_map_with_l_members = yes; then
! AC_DEFINE(HAVE_STRUCT_LINK_MAP_WITH_L_MEMBERS)
fi
dnl Check for struct link_map with lm_ members which are indicative
--- 781,790 ----
gdb_cv_have_struct_link_map_with_l_members=no)])
AC_MSG_RESULT($gdb_cv_have_struct_link_map_with_l_members)
if test $gdb_cv_have_struct_link_map_with_l_members = yes; then
! AC_DEFINE(HAVE_STRUCT_LINK_MAP_WITH_L_MEMBERS,1,
! [Define if <link.h> exists and defines struct link_map which has
! members with an ``l_'' prefix. (For Solaris, SVR4, and
! SVR4-like systems.)])
fi
dnl Check for struct link_map with lm_ members which are indicative
*************** if test ${host} = ${target} ; then
*** 782,788 ****
gdb_cv_have_struct_link_map_with_lm_members=no)])
AC_MSG_RESULT($gdb_cv_have_struct_link_map_with_lm_members)
if test $gdb_cv_have_struct_link_map_with_lm_members = yes; then
! AC_DEFINE(HAVE_STRUCT_LINK_MAP_WITH_LM_MEMBERS)
fi
dnl Check for struct so_map with som_ members which are found on
--- 799,807 ----
gdb_cv_have_struct_link_map_with_lm_members=no)])
AC_MSG_RESULT($gdb_cv_have_struct_link_map_with_lm_members)
if test $gdb_cv_have_struct_link_map_with_lm_members = yes; then
! AC_DEFINE(HAVE_STRUCT_LINK_MAP_WITH_LM_MEMBERS, 1,
! [Define if <link.h> exists and defines struct link_map which has
! members with an ``lm_'' prefix. (For SunOS.)])
fi
dnl Check for struct so_map with som_ members which are found on
*************** if test ${host} = ${target} ; then
*** 800,806 ****
gdb_cv_have_struct_so_map_with_som_members=no)])
AC_MSG_RESULT($gdb_cv_have_struct_so_map_with_som_members)
if test $gdb_cv_have_struct_so_map_with_som_members = yes; then
! AC_DEFINE(HAVE_STRUCT_SO_MAP_WITH_SOM_MEMBERS)
fi
dnl Check for struct link_map32 type, which allows a 64-bit Solaris
--- 819,827 ----
gdb_cv_have_struct_so_map_with_som_members=no)])
AC_MSG_RESULT($gdb_cv_have_struct_so_map_with_som_members)
if test $gdb_cv_have_struct_so_map_with_som_members = yes; then
! AC_DEFINE(HAVE_STRUCT_SO_MAP_WITH_SOM_MEMBERS, 1,
! [Define if <link.h> exists and defines a struct so_map which has
! members with an ``som_'' prefix. (Found on older *BSD systems.)])
fi
dnl Check for struct link_map32 type, which allows a 64-bit Solaris
*************** if test ${host} = ${target} ; then
*** 814,821 ****
gdb_cv_have_struct_link_map32=no)])
AC_MSG_RESULT($gdb_cv_have_struct_link_map32)
if test $gdb_cv_have_struct_link_map32 = yes; then
! AC_DEFINE(HAVE_STRUCT_LINK_MAP32)
! AC_DEFINE(_SYSCALL32)
fi
fi
--- 835,844 ----
gdb_cv_have_struct_link_map32=no)])
AC_MSG_RESULT($gdb_cv_have_struct_link_map32)
if test $gdb_cv_have_struct_link_map32 = yes; then
! AC_DEFINE(HAVE_STRUCT_LINK_MAP32, 1,
! [Define if <sys/link.h> has struct link_map32])
! AC_DEFINE(_SYSCALL32, 1,
! [Define if <sys/link.h> has link_map32 (solaris sparc-64 target)])
fi
fi
*************** if test ${build} = ${host} -a ${host} =
*** 934,940 ****
if test -f /usr/include/dce/cma_config.h ; then
if test "$GCC" = "yes" ; then
AC_MSG_RESULT(yes)
! AC_DEFINE(HAVE_HPUX_THREAD_SUPPORT)
CONFIG_OBS="${CONFIG_OBS} hpux-thread.o"
CONFIG_SRCS="${CONFIG_SRCS} hpux-thread.c"
else
--- 957,964 ----
if test -f /usr/include/dce/cma_config.h ; then
if test "$GCC" = "yes" ; then
AC_MSG_RESULT(yes)
! AC_DEFINE(HAVE_HPUX_THREAD_SUPPORT, 1,
! [Define if you have HPUX threads])
CONFIG_OBS="${CONFIG_OBS} hpux-thread.o"
CONFIG_SRCS="${CONFIG_SRCS} hpux-thread.c"
else
*************** if test ${build} = ${host} -a ${host} =
*** 952,958 ****
AC_MSG_CHECKING(for Solaris thread debugging library)
if test -f /usr/lib/libthread_db.so.1 ; then
AC_MSG_RESULT(yes)
! AC_DEFINE(HAVE_THREAD_DB_LIB)
CONFIG_OBS="${CONFIG_OBS} sol-thread.o"
CONFIG_SRCS="${CONFIG_SRCS} sol-thread.c"
AC_CHECK_LIB(dl, dlopen)
--- 976,983 ----
AC_MSG_CHECKING(for Solaris thread debugging library)
if test -f /usr/lib/libthread_db.so.1 ; then
AC_MSG_RESULT(yes)
! AC_DEFINE(HAVE_THREAD_DB_LIB, 1,
! [Define if using Solaris thread debugging.])
CONFIG_OBS="${CONFIG_OBS} sol-thread.o"
CONFIG_SRCS="${CONFIG_SRCS} sol-thread.c"
AC_CHECK_LIB(dl, dlopen)
*************** if test ${build} = ${host} -a ${host} =
*** 982,988 ****
])
AC_MSG_RESULT($gdb_cv_proc_service_is_old)
if test $gdb_cv_proc_service_is_old = yes; then
! AC_DEFINE(PROC_SERVICE_IS_OLD)
fi
else
AC_MSG_RESULT(no)
--- 1007,1015 ----
])
AC_MSG_RESULT($gdb_cv_proc_service_is_old)
if test $gdb_cv_proc_service_is_old = yes; then
! AC_DEFINE(PROC_SERVICE_IS_OLD, 1,
! [Define if <proc_service.h> on solaris uses int instead of
! size_t, and assorted other type changes.])
fi
else
AC_MSG_RESULT(no)
*************** if test "x$ac_cv_header_sys_syscall_h" =
*** 1039,1046 ****
fi
dnl See if we can issue tkill syscall.
if test "x$gdb_cv_sys_syscall_h_has_tkill" = "xyes" && test "x$ac_cv_func_syscall" = "xyes"; then
! AC_DEFINE(HAVE_TKILL_SYSCALL, 1,
! [Define if we can use the tkill syscall.])
fi
dnl Handle optional features that can be enabled.
--- 1066,1072 ----
fi
dnl See if we can issue tkill syscall.
if test "x$gdb_cv_sys_syscall_h_has_tkill" = "xyes" && test "x$ac_cv_func_syscall" = "xyes"; then
! AC_DEFINE(HAVE_TKILL_SYSCALL, 1, [Define if you support the tkill syscall.])
fi
dnl Handle optional features that can be enabled.
*************** if test "${ignore_sim}" = "true"; then
*** 1362,1368 ****
else
IGNORE_SIM=""
IGNORE_SIM_OBS=""
! AC_DEFINE(WITH_SIM)
fi
AC_SUBST(IGNORE_SIM)
AC_SUBST(IGNORE_SIM_OBS)
--- 1388,1394 ----
else
IGNORE_SIM=""
IGNORE_SIM_OBS=""
! AC_DEFINE(WITH_SIM, 1, [Define if the simulator is being linked in.])
fi
AC_SUBST(IGNORE_SIM)
AC_SUBST(IGNORE_SIM_OBS)
*************** if test "${hostfile}" != ""; then
*** 1485,1491 ****
esac
files="${files} ${GDB_XM_FILE}"
links="${links} xm.h"
! AC_DEFINE_UNQUOTED(GDB_XM_FILE, "${GDB_XM_FILE}")
fi
AC_SUBST(xm_h)
--- 1511,1517 ----
esac
files="${files} ${GDB_XM_FILE}"
links="${links} xm.h"
! AC_DEFINE_UNQUOTED(GDB_XM_FILE, "${GDB_XM_FILE}", [hostfile])
fi
AC_SUBST(xm_h)
*************** if test "${targetfile}" != ""; then
*** 1499,1505 ****
esac
files="${files} ${GDB_TM_FILE}"
links="${links} tm.h"
! AC_DEFINE_UNQUOTED(GDB_TM_FILE, "${GDB_TM_FILE}")
fi
AC_SUBST(tm_h)
--- 1525,1531 ----
esac
files="${files} ${GDB_TM_FILE}"
links="${links} tm.h"
! AC_DEFINE_UNQUOTED(GDB_TM_FILE, "${GDB_TM_FILE}", [targetfile])
fi
AC_SUBST(tm_h)
*************** if test "${nativefile}" != ""; then
*** 1513,1519 ****
esac
files="${files} ${GDB_NM_FILE}"
links="${links} nm.h"
! AC_DEFINE_UNQUOTED(GDB_NM_FILE, "${GDB_NM_FILE}")
fi
AC_SUBST(nm_h)
--- 1539,1545 ----
esac
files="${files} ${GDB_NM_FILE}"
links="${links} nm.h"
! AC_DEFINE_UNQUOTED(GDB_NM_FILE, "${GDB_NM_FILE}", [nativefile])
fi
AC_SUBST(nm_h)