This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] pb unwinding from pthread_cond_wait on ppc-linux (RFA?)


On Wed, Feb 09, 2005 at 12:02:11PM -0500, Joel Brobecker wrote:
> Ping?

You may want to ping at Andrew and Kevin directly about this.

> On Thu, Dec 09, 2004 at 05:00:17PM +0100, Joel Brobecker wrote:
> > > Precisely!  That's what I thought it would be.  It's trying to load lr
> > > with the address of @+16, so that the function can access PIC data
> > > using PC-relative displacement.
> > 
> > Daniel, you never stop to impress me.
> > 
> > > (Does this obsolete the "branch in first three insns" check?  I'm not
> > > sure if there are other possible reasons for that.)
> > 
> > Here is a new patch that implements your suggestion. Indeed, I could
> > then remove the "branch in first three insns" check...

FYI, rethinking this, this is not such a good idea (removing the check,
I mean).  While the check itself is pretty bogus, the comment above
says:
        {                       /* bl foo, 
                                   to save fprs??? */

I know at least Darwin does this.

So maybe the new check should be additional instead of a replacement.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]