This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFC] solib-svr4.c gdb_byteised.
- From: Manoj Iyer <manjo at austin dot ibm dot com>
- To: "M.M. Kettenis" <m dot m dot kettenis at alumnus dot utwente dot nl>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Tue, 31 May 2005 09:34:22 -0500 (CDT)
- Subject: Re: [RFC] solib-svr4.c gdb_byteised.
- References: <7320928157066569@webhare> <Pine.LNX.4.58.0505261740040.13210@lazy>
Mark,
Any comments? ok to commit?
>
> > > solib-svr4.c compiles without errors on ppc64 with gcc4.0. Here is a
> > > patch...
> > >
> > >
> > > 2005-05-26 Manoj Iyer <manjo@austin.ibm.com>
> > >
> > > * solib-svr4.c: lm_info structure convert type of lm to gdb_byte.
> > > (elf_locate_base): Converted types of buf, bufend, pbuf, to gdb_byte.
> > > (first_link_map_member): Converted type of r_map_buf to gdb_byte.
> > > (open_symbol_file_object): Converted type of l_name_buf to gdb_byte.
> > > (svr4_fetch_objfile_link_map): Converted type of l_name_buf to
> > > gdb_byte.
> >
> > I think the l_name_buf change is wrong since it *is* supposed to be
> > a (character) string.
>
>
> gcc4.0 complained abt the signedness...
>
> reversing gdb_byte to char for l_name_buf :
>
>
> /opt/gcc-nightly/4.0-20050526/bin/cc -m64 -c -m64 -mminimal-toc -I.
> -I.././gdb -I.././gdb/config -DLOCALEDIR="\"/usr/local/share/locale\""
> -DHAVE_CONFIG_H -I.././gdb/../include/opcode -I.././gdb/../readline/..
> -I../bfd -I.././gdb/../bfd -I.././gdb/../include -I../intl
> -I.././gdb/../intl -DMI_OUT=1 -Wimplicit -Wreturn-type -Wcomment
> -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wformat-nonliteral
> -Wunused-label -Wunused-function solib-svr4.c
> solib-svr4.c: In function â??open_symbol_file_objectâ??:
> solib-svr4.c:533: warning: pointer targets in passing argument 2 of
> â??read_memoryâ?? differ in signedness
> solib-svr4.c:537: warning: pointer targets in passing argument 1 of
> â??extract_unsigned_integerâ?? differ in signedness
> solib-svr4.c: In function â??svr4_fetch_objfile_link_mapâ??:
> solib-svr4.c:707: warning: pointer targets in passing argument 2 of
> â??read_memoryâ?? differ in signedness
> solib-svr4.c:711: warning: pointer targets in passing argument 1 of
> â??extract_unsigned_integerâ?? differ in signedness
> Making init.c
>