This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Humpf, with the patch, this time. Thanks Daniel! On Mon, May 30, 2005 at 03:45:38PM +1000, Joel Brobecker wrote: > > > #define TRY_CATCH(EXCEPTION,MASK) \ > > > { \ > > > EXCEPTIONS_SIGJMP_BUF *buf = \ > > > exceptions_state_mc_init (uiout, &(EXCEPTION), (MASK)); \ > > > EXCEPTIONS_SIGSETJMP (*buf); \ > > > } \ > > > while (exceptions_state_mc_action_iter ()) \ > > > while (exceptions_state_mc_action_iter_1 ()) > > > > > > There is a dependency on "uiout". Perhaps it would be better to include > > > that file from exceptions.h, rather than requiring all clients to include > > > it themselves? I could send a separate RFA for that. > > > > Yes please. I figured it was something like that, went looking at the > > definition, and my eyes skipped right over it. > > Sure. Patch sent, although I can provide the URL yet, as sources.redhat.com > is unfortunately refusing connections on port 25. Will send the URL as > a followup message as soon as the problem is fixed. > > > > > Also, I am not convinced that the new TRY_CATCH is necessary. The > > > > only bit likely to throw is print_symbol, which is already wrapped in > > > > catch_errors. > > > > > > That's true, and I'd be happy to remove it. But I thought that it might > > > be safer to use it anyway, so that any change underneath that might cause > > > an exception to be thrown does not affect this code. This is a hard > > > guaranty that the language will never be changed as a side-effect of > > > this command. > > Okidoke, understood. New patch attached. > > 2005-05-30 Joel Brobecker <brobecker@adacore.com> > > * symmisc.c (dump_symtab_1): Renamed from dump_symtab. > (dump_symtab): New function. > > Tested on x86-linux. -- Joel
Attachment:
symmisc.c.diff
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |