This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFA] Add missing include dependency in exceptions.h


Hello,

See http://sources.redhat.com/ml/gdb-patches/2005-05/msg00601.html.

The TRY_CATCH macro has a dependency on "uiout", which is declared in
ui-out.h. Because this header is not included in exceptions.h, any file
that uses this macro needs to include "ui-out.h". I think we should
include "ui-out.h" in "exceptions.h" instead. This is what this patch
does.

Note that another alternative would be to add something like:

        extern struct ui_out *uiout;

to exceptions.h. I personnaly think it would be ugly to sprinkle
such extern declarations everywhere...

2005-05-30  Joel Brobecker  <brobecker@adacore.com>

        * exceptions.h: Include ui-out.h.
        (ui_out): Remove declaration.
        * Makefile.in (exceptions_h): Add dependency on ui-out.h.

Tested on x86-linux.
OK to apply?

Thanks,
-- 
Joel

Attachment: uiout.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]