This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: mi tty commands


On Sun, May 29, 2005 at 09:55:23AM +0300, Eli Zaretskii wrote:
> > +Show terminal for future runs of program being debugged.
> 
> I think the ``future'' part should be removed from this sentence: what
> this command outputs is the terminal used _now_ as well as in the
> future.

That's not strictly true.  It is the terminal that will be used the
next time we start the program; we don't know at this point whether
it's currently in use or whether the user has changed it since we last
started the program.  We don't have any way to change it in mid-flight.

> 	* nto-procfs.c (procfs_create_inferior)
> 	* win32-nat.c (child_create_inferior): Use get_inferior_io_terminal.
> 
> Note how I used the explicit name of the function used, instead of
> just "accessor function".

Did you mean:
	* nto-procfs.c (procfs_create_inferior): Use
	get_inferior_io_terminal.
	* win32-nat.c (child_create_inferior): Likewise.

?

I thought it was incorrect to have no colon and log message
corresponding to a bullet.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]