This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Is this kind of patch welcomed?


On Sat, 28 May 2005, Daniel Jacobowitz wrote:

> I've committed it with this ChangeLog:
> 2005-05-28  Daniel Jacobowitz  <dan@codesourcery.com>
> 
>         From Wu Zhou <woodzltc@cn.ibm.com>:
>         * remote.c (struct gdb_ext_thread_info): Fix a comment typo.
>         (remote_unpack_thread_info_response): Likewise.

Thanks for commiting this.  BTW, could I get the Write After Approval
access?  It is said that I need a valid FSF assignment and had ever 
submitted one good patch.  Who could recommend me for this? Thanks a
lot!

> 
> [The comments are still formatted badly, but that's no excuse not to
> fix the spelling!]
> 

OK.  What is the good style for the comments?  I guess that you might
means that the first comment should be in one line other than the code,
and the second comment should set its first character in uppercase, 
right?  I'd like to code another patch if you tell me what is the right
format.  Thanks.

Cheers
- Wu Zhou


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]