This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: cp-name-parser.y


> Date: Sat, 28 May 2005 12:49:59 -0400
> From: Daniel Jacobowitz <drow@false.org>

> On Sat, May 28, 2005 at 10:22:27AM -0400, Daniel Jacobowitz wrote:
> > On Sat, May 28, 2005 at 10:58:31AM +0200, Hans-Peter Nilsson wrote:
> > > It takes two looks.
> > 
> > Maybe it takes three?

Probably; I incorrectly assumed that the code that person wrote
was correct to the main parts and didn't review it's semantics.
I hope to avoid that in the future. :-)

>  Your patch is incorrect, since it is covering up
> > a real problem.  It ought to be "return c".
> 
> Like so.  Checked with GCC 4.1.0 20050508 and committed.

Thanks.

brgds, H-P


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]