This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [commit] gdb_byte part of ppc
Manoj Iyer wrote:
I send out a similar patch for review yestarday and it covers a few more
files, any comments on that one?
Oops :-( If you look carefully through what I committed you'll notice:
rs6000_fetch_pointer_argument (struct frame_info *frame, int argi,
struct type *type)
{
- CORE_ADDR addr;
- get_frame_register (frame, 3 + argi, &addr);
- return addr;
+ return get_frame_register_unsigned (frame, 3 + argi);
}
See the problem? I don't seem to be able to find that change in your
patch which puzzles me. With the combination of gcc4, gdb_byte, and
-Werror I couldn't miss it.
Can I suggest installing gcc4 and then using that to build gdb
(configured with --enable-gdb-warnings=,-Werror) and look at the
problems identified (you can override -Werror forcing a successful build
using `cd ...build/gdb && make WERROR_CFLAGS=` )? Warning fixes to
*ppc* files identified doing that are fairly obvious (I keep finding the
need to make related changes).
That leaves the s/unsigned char/gdb_byte/, that is probably also obvious
(assuming it isn't leaving warnings behind).