This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFA/alpha] Use correct register for FP branches in alpha_next_pc()


Blush... Obvious mistake ... 

I looked at the 18 failures I currently have when running the following
testcase (not yet approved):

        http://sources.redhat.com/ml/gdb-patches/2005-05/msg00546.html

It turns out it was an obvious confusion between the register number
embedded in the instruction, and hte register number as GDB knows it.
Say for instance we have a conditional branch instruction on f16, right
now we read register number 16, which is register a0, not f16! The fix
I just committed seemed to be improving things, but only by chance :-/.
With the attached patch, all tests now PASS.

2005-05-26  Joel Brobecker  <brobecker@adacore.com>

        * alpha-tdep.c (alpha_next_pc): Use correct register number
        for floating-point branch instructions.

Tested on alpha-tru64 5.1a. No regression, fixes all 18 failures
observed in alpha-step.exp.

OK to apply?
-- 
Joel

Attachment: alpha-tdep.c.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]