This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA/alpha] Add handling of FP control insn in software-single step
- From: Richard Henderson <rth at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Mon, 16 May 2005 23:30:32 -0700
- Subject: Re: [RFA/alpha] Add handling of FP control insn in software-single step
- References: <20050517023400.GW1462@adacore.com>
On Tue, May 17, 2005 at 12:34:00PM +1000, Joel Brobecker wrote:
> +static int
> +fp_register_sign_bit (char *buf)
> +{
> + return (buf[0] & 0x80);
Also, this is a big-endian test.
> + regcache_cooked_read (current_regcache, (insn >> 21) & 0x1f, reg);
> /* Need to determine if branch is taken; read RA. */
> - rav = (LONGEST) read_register ((insn >> 21) & 0x1f);
> + rav = extract_signed_integer (reg, 4);
And you're only extracting 4 bytes instead of 8.
So, basically, not one part of the patch is correct.
r~