This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [commit/cris] Add guru mode setting for CRISv32
- From: "Eli Zaretskii" <eliz at gnu dot org>
- To: Orjan Friberg <orjan dot friberg at axis dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 13 May 2005 16:14:11 +0300
- Subject: Re: [commit/cris] Add guru mode setting for CRISv32
- References: <42849D2B.9030905@axis.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Fri, 13 May 2005 14:27:23 +0200
> From: Orjan Friberg <orjan.friberg@axis.com>
>
> Committed the following.
>
> 2005-05-13 Orjan Friberg <orjanf@axis.com>
>
> * cris-tdep.c (usr_cmd_cris_version): Change type to int.
> (cris_mode_normal, cris_mode_guru, cris_modes, usr_cmd_cris_mode): Add.
> (struct gdbarch_tdep): Change type of cris_version to int. Add
> cris_mode.
> (cris_mode, set_cris_mode): New functions.
> (crisv32_single_step_through_delay): Read from NRP register instead
> of ERP register in guru mode.
> (cris_breakpoint_from_pc): Rename break_insn to break8_insn.
> Add break15_insn, returned in guru mode.
> (_initialize_cris_tdep): Add call to add_setshow_enum_cmd for new
> cris-mode setting.
> (cris_dump_tdep): Add dump of cris_mode.
> (cris_gdbarch_init): Add cris_mode to search criteria for architecture.
> Register the sigtramp frame sniffer only if not in guru mode.
Thanks.
These patches introduced new user-level commands, but didn't include
any documentation for them, neither in the command's built-in
documentation nor in the manual. Please in the future _always_
accompany user-level changes with a suitable documentation changes.
Since the code is already in the CVS, I'm asking you to please post
documentation patches for these commands as soon as you can. There's
a "CRIS" subsection in the manual where the description should go.
Also, please improve the doc strings of the new setting you added:
they at least should list the possible settings for cris-mode.
TIA