This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [COMMIT] Avoid compiler warnings in gnu-v3-abi.c


On Thu, May 12, 2005 at 11:45:01PM +0300, Eli Zaretskii wrote:
> > Date: Thu, 12 May 2005 11:33:41 -0400
> > From: Daniel Jacobowitz <drow@false.org>
> > 
> > What compiler version produced this warning?  GCC 3.3 and 3.4 don't,
> > AFAICT; maybe it's new in 4.0.
> 
> I used GCC 3.4.3.  Perhaps it's a matter of what warning options are
> turned on?  The ones I used are in the current CVS's djconfig.sh.
> 
> Are you saying that this is a GCC bug?  I don't think so, since the
> code is clearly unclean: it mixes two different enums.  GCC is right
> warning about that.

Yes, the patch is definitely right.  I hadn't thought that GCC 3.4.3
generated the warning, but I only checked 3.3.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]