This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: fix libiberty/pex-djgpp.c


> Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org,
>    djgpp-workers@delorie.com
> From: Ian Lance Taylor <ian@airs.com>
> Date: 11 May 2005 16:28:30 -0400
> 
> You don't need pex_djgpp_fdopenr.  It will only be called if
> pex_init_common is called with PEX_USE_PIPES

It's not easy to figure out what is needed and in what conditions.  It
would be nice if this machinery were to be documented a bit more
methodically.  Right now, the information is scattered between
pex-common.h, include/libiberty.h and a few comments in pex-*.c files.

> Otherwise, this patch is approved.  Please check it into the gcc
> repository first, as usual with libiberty patches.

I don't think I have write access to the GCC repository, sorry.

Anyway, thanks for a timely review.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]