This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: fix libiberty/pex-djgpp.c
- From: "Eli Zaretskii" <eliz at gnu dot org>
- To: djgpp-workers at delorie dot com
- Cc: gcc-patches at gcc dot gnu dot org, gdb-patches at sourceware dot org
- Date: Thu, 12 May 2005 02:23:44 +0300
- Subject: Re: RFA: fix libiberty/pex-djgpp.c
- References: <01c5565c$Blat.v2.4$082130a0@zahav.net.il> <m3y8alqzgx.fsf@gossamer.airs.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org,
> djgpp-workers@delorie.com
> From: Ian Lance Taylor <ian@airs.com>
> Date: 11 May 2005 16:28:30 -0400
>
> You don't need pex_djgpp_fdopenr. It will only be called if
> pex_init_common is called with PEX_USE_PIPES
It's not easy to figure out what is needed and in what conditions. It
would be nice if this machinery were to be documented a bit more
methodically. Right now, the information is scattered between
pex-common.h, include/libiberty.h and a few comments in pex-*.c files.
> Otherwise, this patch is approved. Please check it into the gcc
> repository first, as usual with libiberty patches.
I don't think I have write access to the GCC repository, sorry.
Anyway, thanks for a timely review.