This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Unconditionally include shared library code


   Date: Sun, 8 May 2005 10:40:20 -0400
   From: Daniel Jacobowitz <drow@false.org>

   > But the problem I'm addressing here is solib.h.  It contains both the
   > prototypes for the functions in solib.c and the #defines for the hooks
   > that make core GDB use those functions.  Since the goal of my patch is
   > to get away from using those #defines, I can't simply #include solib.h
   > in the core GDB source files, unless I do a massive conversion of all
   > targets using solib.h.  That, I think is rather dangerous.  I'd rather
   > convert them one-by one, after I've verified that indeed they work
   > using the new mechanism.

   What bugs me about it is that it's not clear which one is going away.
   Would this alternative work for you?  Create a new file, solib-macros.h,
   and move the macros from solib.h there.  Have any targets which
   currently include solib.h via their TM_FILE include solib-macros.h
   instead, which is a nice mechanical update.

Hmm, that'd work.  We'll have to face the inconsistent interface issue
eventually, but it's a seperate issue indeed.  Any objection if I
introduce a config/tm-solib.h and use that?  Its purpose is a bit more
clear, and the risk of abuse is smaller.  The mechanical update is not
without risk, but I'm willing to take it.  Deal?

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]