This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: fullname syntax variable for testsuite


On Fri, May 06, 2005 at 11:12:58PM -0400, Bob Rossi wrote:
> On Thu, May 05, 2005 at 09:54:42PM -0400, Daniel Jacobowitz wrote:
> > On Thu, May 05, 2005 at 08:44:15PM -0400, Bob Rossi wrote:
> > > Here is the updated patch. I broke down the regexp into several cases.
> > > It should be very easy to maintain (add/remove) the regexp as time goes
> > > on. If there are any other modifications that need to be made, please
> > > let me know.
> > > 
> > > Thanks,
> > > Bob Rossi
> > > 
> > > 
> > > 2005-05-05  Bob Rossi  <bob_rossi@cox.net>
> > > 
> > >     * lib/gdb.exp (fullname_syntax): Added global regex.
> > >     (fullname_syntax_POSIX): Ditto.
> > >     (fullname_syntax_UNC): Ditto.
> > >     (fullname_syntax_DOS_CASE): Ditto.
> > >     (fullname_syntax_DOS): Ditto.
> > >     * gdb.mi/mi-file.exp (test_file_list_exec_source_file): Added
> > >     fullname_syntax variable to scope and use it.
> > >     (test_file_list_exec_source_files): Ditto.
> > >     * gdb.mi/mi2-file.exp (test_file_list_exec_source_file): Ditto.
> > 
> > This patch is OK with me.  Please wait a day to see if anyone else has
> > comments, and then you can check this in.  After you do that I'll
> > revise Dennis's patch.
> 
> I changed the DOS_CASE 
>    from set fullname_syntax_DOS_CASE {\\[^\\]+\\}
>    to set fullname_syntax_DOS_CASE {\\[^\\].*\\}
> as Dennis noticed, it didn't match the regex
>     \a\b\c\d\basics.c
> 
> Anyways, please consider this as a last chance to speak up with any
> problems. Otherwise, I'll commit tomorrow.

Committed.

Bob Rossi


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]